The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: draganescu <andraganescu@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Co-authored-by: kevin940726 <kevin940726@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Size Change: +59 B (0%)

Total Size: 1.77 MB

_{compressed-size-action}

Could we just show duplicate and delete? I find having group, ungroup, and create pattern to be an odd experience, in particular group/ungroup as nothing changes visually:

@annezazu I had just deleted them yes.

Hmm noticing an empty menu randomly. I'm not quite sure why it appears but I can replicate it if I play around with this PR enough:

Here's a quick video where this showed up:

I'd expect "Copy" as well.

Perhaps "add before" and "add after", though those could be separate—to engage with the zoom out behavior that occurs when using one of those inserters.

This is what I'd consider ideal:

Hmm noticing an empty menu randomly. I'm not quite sure why it appears but I can replicate it if I play around with this PR enough:

I suspect it's from the grouping you did, which is now gone. Does it still appear after that change?

@richtabor Copy was intentionally removed in #61127. Are you sure we should restore it here?

@getdave Does this appear in trunk as well? What content do you have to reproduce it?

Ah, I see it on the demo page actually, sorry.

We ehave no guarantee what kind of selection this applies to so the contents of the settings dropdown varies a lot.

@getdave So the reason you see that button is because #65560 (from @youknowriad) was not backported.

I'm still seeing "create pattern" as an option.

I suspect it's from the grouping you did, which is now gone. Does it still appear after that change?

Can't replicate anymore 🥳

@getdave So the reason you see that button is because #65560 (from @youknowriad) was not backported.

Looks like we now have that PR backported in #66339.

Testing locally with the backport applied I'm still seeing the rogue menu items when editing Pages in the Site Editor.

These items are adding a lot of additional complexity to Zoom Out mode in 6.7. As such I"m bumping up the priority on this one with a view to finding a fix before RC2 next week.

I think we should be aiming for this UI which also means getting rid of the Create Pattern menu item:

Testing on a Page I saw options relating to Edit template. However the block I'm interacting with is not part of the template.

I've pushed a commit that may solve that (feel free to do what you want with it!), essentially not showing those options for any children of the post content block. I think this makes sense, as the children of Post Content are not ever considered part of the template AFAIK.

I'm still seeing 'Create pattern' a lot when testing.

Thanks @talldan. This does indeed solve the Issue of the unwanted "Template" items in the Site Editor.

Unfortunately it does not seem to fix the Post Editor (try editing the same Page in the Post Editor). I still see the Template items which is of course expected because the core/post-content block will not exist in the Post Editor.

I'm wonder whether we just skip rendering these items in Zoom Out mode? It's unlikely we'd ever want them. I feel like this is a valid case to tie this logic to.

Also, @richtabor how do you feel about getting ride of the Create Pattern option only in Zoom Out? I don't want this question to block merging this PR but if we can tackle two problems with one PR that might also be nice.

Noted above on my end but I’d like create pattern to go away personally. It’s a confusing UX as is if you click it.

Why didn't we rebase this first?

Given @getdave's commit, I'll revert my one.

Why didn't we rebase this first?

Now done. Rather than revert I dropped the commit I added, as it meant not solving a conflict.

Was there some other change in wp/6.7 that would be beneficial?

Was there some other change in wp/6.7 that would be beneficial?

I think #66339

Well, looking at the latest changes that component is now entirely hidden? Is that needed after #66339?

Well, looking at the latest changes that component is now entirely hidden? Is that needed after #66339?

I rebase against latest wp/6.7. If you reset the HEAD to remove my last commit you'll see it still doesn't fix the problem when editing Pages 😬

Flaky tests detected in 0050f8a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11659714780
📝 Reported issues:

• [Flaky Test] submenu click on the arrow interactions #61884 in /test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js

Also, @richtabor how do you feel about getting ride of the Create Pattern option only in Zoom Out? I don't want this question to block merging this PR but if we can tackle two problems with one PR that might also be nice.

Yes, let's take it out.

I've added copy back and removed the pattern related group of options.

Should this be targeted at 6.7? Technically, it's a feature, and we're already in the RC phase. Could we punt this to 6.7.1 or 6.8? Sorry if I'm missing something! c.c. @colorful-tones @ndiego

The main piece we need for 6.7 is the ability to delete using the more menu. I say this needs to land for the release.

I rebased the branch to see if it passes the CI.

We also need this merged addressed in trunk.